Skip to content

Add codex-mcp-internal server exposing internal tooling#112

Merged
hackall360 merged 1 commit intoLMStudiofrom
codex/clarify-codex-mcp-server-functionality
Sep 29, 2025
Merged

Add codex-mcp-internal server exposing internal tooling#112
hackall360 merged 1 commit intoLMStudiofrom
codex/clarify-codex-mcp-server-functionality

Conversation

@hackall360
Copy link
Owner

Summary

  • add a new codex-mcp-internal binary that launches the MCP server in internal tooling mode
  • implement an InternalToolRegistry to expose shell, apply_patch, update_plan, and view_image tools over MCP
  • make the message processor mode-aware so the internal server can list and handle internal tools while still supporting the gateway

Testing

  • just fmt
  • just fix -p codex-mcp-server
  • cargo test -p codex-mcp-server

https://chatgpt.com/codex/tasks/task_b_68d9e57199e4832f9f5a2057c2b520eb

@hackall360 hackall360 merged this pull request into LMStudio Sep 29, 2025
3 of 6 checks passed
@hackall360 hackall360 deleted the codex/clarify-codex-mcp-server-functionality branch September 29, 2025 05:30
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

match subcommand {
McpSubcommand::Serve => {
codex_mcp_server::run_main(codex_linux_sandbox_exe, config_overrides).await?;

[P0] Fix CLI compile error after run_main API change

The new codex_mcp_server::run_main now requires a ServerMode argument, but the CLI still invokes it with only the sandbox path and config overrides. This call no longer matches the function signature and causes the codex-cli crate to stop compiling when building the workspace. Pass the appropriate ServerMode (likely ServerMode::CodexGateway) here so the CLI continues to build.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant